[CHANGED] Rate limit (some) similar warnings #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some warnings, especially when dealing with JS limits that were printed on a per-message basis, are now limited to ~1 per second if the content of the warning is already found in a map. This is also for "client" warnings, but the client porting of the warning is not taken into account so that helps with reducing logging for similar content, but coming from different clients. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
changed the title
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@derekcollison Made some changes that move the initialization of the channel when creating the server and remove casting by making it a channel of time.Duration. Also changed the store value to time.Time instead of int64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some warnings, especially when dealing with JS limits that were
printed on a per-message basis, are now limited to ~1 per second
if the content of the warning is already found in a map.
This is also for "client" warnings, but the client porting of the
warning is not taken into account so that helps with reducing logging
for similar content, but coming from different clients.
Signed-off-by: Ivan Kozlovic ivan@synadia.com