Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on shutdown with meta being nil #2999

Merged
merged 1 commit into from
Apr 4, 2022
Merged

fix crash on shutdown with meta being nil #2999

merged 1 commit into from
Apr 4, 2022

Conversation

matthiashanel
Copy link
Contributor

Signed-off-by: Matthias Hanel mh@synadia.com

fixes

--- FAIL: TestJetStreamSystemLimitsPlacement (2.99s)
    --- PASS: TestJetStreamSystemLimitsPlacement/file_create_large_stream_on_small_server (0.00s)
    --- PASS: TestJetStreamSystemLimitsPlacement/memory_create_large_stream_on_small_server (0.00s)
    --- PASS: TestJetStreamSystemLimitsPlacement/file_create_large_stream_on_medium_server (0.00s)
    --- PASS: TestJetStreamSystemLimitsPlacement/memory_create_large_stream_on_medium_server (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x88 pc=0x8fed6e]
goroutine 193037 [running]:
testing.tRunner.func1.2(0x10003a0, 0x17d2360)
	/home/travis/.gimme/versions/go1.16.15.linux.amd64/src/testing/testing.go:1153 +0x332
testing.tRunner.func1(0xc00045cd80)
	/home/travis/.gimme/versions/go1.16.15.linux.amd64/src/testing/testing.go:1156 +0x4b6
panic(0x10003a0, 0x17d2360)
	/home/travis/.gimme/versions/go1.16.15.linux.amd64/src/runtime/panic.go:965 +0x1b9
github.com/nats-io/nats-server/v2/server.(*Server).migrateEphemerals(0xc001e7ac00)
	/home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream.go:777 +0xae
github.com/nats-io/nats-server/v2/server.(*Server).Shutdown(0xc001e7ac00)
	/home/travis/gopath/src/github.com/nats-io/nats-server/server/server.go:1845 +0x7d
github.com/nats-io/nats-server/v2/server.TestJetStreamSystemLimitsPlacement(0xc00045cd80)
	/home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_test.go:7057 +0xd45
testing.tRunner(0xc00045cd80, 0x1184678)
	/home/travis/.gimme/versions/go1.16.15.linux.amd64/src/testing/testing.go:1203 +0xe5
created by testing.(*T).Run
	/home/travis/.gimme/versions/go1.16.15.linux.amd64/src/testing/testing.go:1248 +0x2b3
FAIL	github.com/nats-io/nats-server/v2/server	443.756s
FAIL

Signed-off-by: Matthias Hanel <mh@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthiashanel matthiashanel merged commit 569328b into main Apr 4, 2022
@matthiashanel matthiashanel deleted the no-meta branch April 4, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants