-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADDED] LeafNode min_version
new option
#3013
Conversation
If set, a server configured to accept leafnode connections will reject a remote server whose version is below that value. Note that servers prior to v2.8.0 are not sending their version in the CONNECT protocol, which means that anything below 2.8.0 would be rejected. Configuration example: ``` leafnodes { port: 7422 min_version: 2.8.0 } ``` The option is a string and can have the "v" prefix: ``` min_version: "v2.9.1" ``` Note that although suffix such as `-beta` would be accepted, only the major, minor and update are used for the version comparison. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks.
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@matthiashanel @philpennock @davidkemper Do you guys want to do a review or is Derek's LGTM enough and I can merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. ok with logic in general
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@matthiashanel Implemented the requested changes. Have a second look when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If set, a server configured to accept leafnode connections will
reject a remote server whose version is below that value. Note
that servers prior to v2.8.0 are not sending their version
in the CONNECT protocol, which means that anything below 2.8.0
would be rejected.
Configuration example:
The option is a string and can have the "v" prefix:
Note that although suffix such as
-beta
would be accepted,only the major, minor and update are used for the version comparison.
Signed-off-by: Ivan Kozlovic ivan@synadia.com