fix js nex interest check where leaf node masked gw subj propagation #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basically a gw subject propagation issue could be hidden behind a leaf node. also change error text when this was the case Signed-off-by: Matthias Hanel <mh@synadia.com>
kozlovic
reviewed
Apr 8, 2022
The test now passes with code fix. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@matthiashanel I have added the test in commit: bcb0baa. It failed consistently on main branch and passed (at least locally) on your branch. Will see if it fails or not on Travis. |
|
@kozlovic the test looks good to me. Tests failed for unrelated reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically a gw subject propagation issue could be hidden behind a leaf
node.
also change error text when this was the case
Signed-off-by: Matthias Hanel mh@synadia.com