[FIXED] Consumer deliver subject incorrect when imported and crossing a route. #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage crossed a route we dropped the delivered subject. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
consumer_subj_rewrite
branch
from
5336c0d
to
cd7f16f
Compare
matthiashanel
approved these changes
Apr 9, 2022
|
It's not on the subject, its tacked onto the reply subject and we pull that out and set local state and switch on last mile. |
| @@ -4161,6 +4163,11 @@ func (c *client) processMsgResults(acc *Account, r *SublistResult, msg, deliver, | |||
| } else { | |||
| dsubj = append(_dsubj[:0], sub.im.to...) | |||
| } | |||
|
|
|||
| // Make sure deliver is set if inbound from a route. | |||
| if remapped && c.kind == ROUTER { | |||
There was a problem hiding this comment.
What about Leaf and Gateway?
There was a problem hiding this comment.
Possible, just trying to get the fix to pass which it does, and not break any existing tests.
Signed-off-by: Derek Collison <derek@nats.io>
matthiashanel
added a commit
that referenced
this pull request
Apr 11, 2022
… gateway followup to #3017 Signed-off-by: Matthias Hanel <mh@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core