Fixed mixed mode server without JS dropping js export on jwt update #3044
Conversation
Signed-off-by: Matthias Hanel <mh@synadia.com>
Signed-off-by: Matthias Hanel <mh@synadia.com>
Signed-off-by: Matthias Hanel <mh@synadia.com>
Signed-off-by: Matthias Hanel <mh@synadia.com>
server/jwt_test.go
Outdated
|
|
||
| sysNc := natsConnect(t, s.ClientURL(), sUsr, disconnectCb) | ||
| defer sysNc.Close() | ||
| defer sysNc.SetDisconnectErrHandler(nil) |
There was a problem hiding this comment.
FYI: Instead of doing that, you could pass the option nats.NoCallbacksAfterClientClose() in the Connect() call. With that option, the disconnect (and close) handler(s) won't be invoked in Close()
There was a problem hiding this comment.
And you don't need to close the disconnectChan, regardless. You are using a buffered channel, so that won't block the disconnect handler on exit, even if you were not using NoCallbacksAfterClientClose option.
There was a problem hiding this comment.
switched to NoCallbacksAfterClientClose instead of clearing the error handler. thanks for that tip.
I'll keep the channel close, seems off without.
Signed-off-by: Matthias Hanel <mh@synadia.com>
|
|
||
| if s.JetStreamEnabled() { | ||
| // in case of a mixed mode setup, enable js exports anyway | ||
| if s.JetStreamEnabled() || !s.standAloneMode() { |
There was a problem hiding this comment.
Exports always need to be enabled regardless of standalone status.
Signed-off-by: Matthias Hanel mh@synadia.com
The removed code is subsequently handled by addSystemAccountExports.
Right now I am using !standalone as signal to add in the exports. But could add an option, or check for options as well.