Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep jetstream on while using empty config file and reloading #3050

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Keep jetstream on while using empty config file and reloading #3050

merged 1 commit into from
Apr 18, 2022

Conversation

xieyuschen
Copy link
Contributor

@xieyuschen xieyuschen commented Apr 18, 2022 •
edited

Changes proposed in this pull request:

  • merge the JetStream in function MergeOptions.

/cc @nats-io/core

@xieyuschen
Copy link
Contributor Author

xieyuschen commented Apr 18, 2022 •
edited

Hi @matthiashanel @kozlovic @derekcollison , I have fixed the bug reported in #3003 . Could you review it?
Thanks for maintaining the project and reviewing it.

@matthiashanel matthiashanel self-requested a review April 18, 2022 19:08
matthiashanel
matthiashanel approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@matthiashanel matthiashanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xieyuschen Thanks for your submission. I'll merge once tests pass.

@matthiashanel matthiashanel merged commit 322115b into nats-io:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiashanel matthiashanel matthiashanel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xieyuschen @matthiashanel