fix signing key template processing dropping allow #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scoped signing keys allow for optional values in allow rules If an allow rule therefore gets removed because a tag is not present, the removal needs to be compensated by adding in a deny > Signed-off-by: Matthias Hanel <mh@synadia.com>
kozlovic
requested changes
Aug 23, 2022
server/auth.go
Outdated
| @@ -523,6 +527,14 @@ func processUserPermissionsTemplate(lim jwt.UserPermissionLimits, ujwt *jwt.User | |||
| } else if lim.Permissions.Pub.Deny, err = applyTemplate(lim.Permissions.Pub.Deny, true); err != nil { | |||
| return jwt.UserPermissionLimits{}, err | |||
| } | |||
|
|
|||
| // if pub/sub allow where not empty, but are empty post template processing, add in a deny to compensate | |||
There was a problem hiding this comment.
were instead of where. But more importantly, looks like the code is opposite of the comment. That is, you wrote if they were not empty, but are empty after processing add deny. Then should it not be if !subAllowWasEmpty && .. (notice the "!"). Same for the pub.
There was a problem hiding this comment.
wrong variable name. fixed
There was a problem hiding this comment.
thanks for pointing that out
Signed-off-by: Matthias Hanel <mh@synadia.com>
Signed-off-by: Matthias Hanel <mh@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scoped signing keys allow for optional values in allow rules
If an allow rule therefore gets removed because a tag is not present,
the removal needs to be compensated by adding in a deny >
Signed-off-by: Matthias Hanel mh@synadia.com