Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Edge condition handling in {{Split()}} subject mapping function #3463

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

jnmoyne
Copy link
Contributor

@jnmoyne jnmoyne commented Sep 9, 2022

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current main (git pull --rebase origin main)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Resolves a small bug in the {{Split()}} subject mapping function - and of course I just noticed that bug right after 2.9.0 is released :(

/cc @nats-io/core

@kozlovic kozlovic changed the title Fixes edge condition handling in {{Split()}} subject mapping function [FIXED] Edge condition handling in {{Split()}} subject mapping function Sep 9, 2022
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit a41af2b into main Sep 9, 2022
@kozlovic kozlovic deleted the jnm/fix_mapping_split branch September 9, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants