[FIXED] Multiple issues with concurrent stream create requests. #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First issue was applications not getting any response. However, there was also a more serious issue that would create multiple raft groups for each concurrent request. The servers would only run one stream monitor loop, however they would update the state to the new raft group's name, so on server restart the stream would be using a different raft group then existing servers. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
requested review from
wallyqs,
ripienaar,
tbeets,
Jarema,
ColinSullivan1 and
piotrpio
| @@ -759,7 +759,7 @@ func (js *jetStream) apiDispatch(sub *subscription, c *client, acc *Account, sub | |||
| jsub := rr.psubs[0] | |||
|
|
|||
| // If this is directly from a client connection ok to do in place. | |||
| if c.kind != ROUTER && c.kind != GATEWAY { | |||
| if c.kind != ROUTER && c.kind != GATEWAY && c.kind != LEAF { | |||
There was a problem hiding this comment.
Would c.kind == CLIENT be better if only ever from a client conn?
There was a problem hiding this comment.
Possibly but this future proofs for new types, like wss etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires stream requests for the same stream be received before any assignments have been quorum'd.
First issue was applications not getting any response. However, there was also a more serious issue that would create multiple raft groups for each concurrent request. The servers would only run one stream monitor loop, however they would update the state to the new raft group's name, so on server restart the stream would be using a different raft group then existing servers.
Also added in protection for when the meta-leader knows about the stream assignment and wants to convert it to a stream info call but the leader has not been elected yet.
Signed-off-by: Derek Collison derek@nats.io
Resolves #3677
/cc @nats-io/core