Do not gather full state for snapshots #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids hust state outputs for streams with many deleted items Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar
force-pushed
the
snapshot_full_state
branch
from
f9b3480
to
9bbc013
Compare
|
fixed |
|
This for dev or could be for main? |
|
If you are certain you don’t use the extra state details to rebuild anything on restore we can do main else dev. |
|
We do not use any of the state tbh.. So edit this PR to merge to main. |
|
Allright, its pointing at main now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids full state outputs for streams with many deleted items
Signed-off-by: R.I.Pienaar rip@devco.net
/cc @nats-io/core