Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logtime_utc default to false #3920

Merged
merged 1 commit into from Feb 28, 2023
Merged

Change logtime_utc default to false #3920

merged 1 commit into from Feb 28, 2023

Conversation

bruth
Copy link
Member

@bruth bruth commented Feb 28, 2023

This ensures that the existing, default behavior of the server emitting the local timezone is not changed.

@bruth
Change logtime_utc default to false
7f7c717 
This ensures that the existing, default behavior of the server emitting the local timezone is not changed.
@bruth bruth requested a review from a team as a code owner February 28, 2023 17:58
neilalexander
neilalexander approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Jarema
Jarema approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 3878e96 into dev Feb 28, 2023
@derekcollison derekcollison deleted the logtime-utc-default branch February 28, 2023 19:59
@wallyqs wallyqs mentioned this pull request Jul 22, 2023
Merged
derekcollison added a commit that referenced this pull request Jul 22, 2023
@derekcollison
Include logtime_utc option into v2.9 series (#4331)
ac24110 
Includes option to log in UTC with commits from following PRs:

#3833
#3920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bruth @neilalexander @Jarema @derekcollison