[ADDED] Support for multi-filter in stream sources #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a behavior where idempotency of re-defining the same stream more than once (with the same attributes) was broken due to the DeepEqual failing due to the StreamSource struct received from the client app not having a value for the `iname` structure field (as it's internal) but the StreamSource struct return from `mset.config()` would have it set. Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
jnmoyne
force-pushed
the
jnm/multifilter_stream_sourcing
branch
from
d8b7177
to
7710638
Compare
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Allows source SubjectTransformDests to be empty even if FilterSubjects is not empty (no subject transformation) Clean up duplicated code Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Jarema
requested changes
Jul 18, 2023
…string arrays to an array of transform config objects containing two fields Removes now un-needed error. Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Jarema
requested changes
Jul 22, 2023
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
… creating a stream (expected to be there by one of the nats.go tests) Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
…ation as it breaks one of the existing JS test:
```
jetstream_cluster_2_test.go:998: Expected to have NO domain set but got "SPOKE"
--- FAIL: TestJetStreamClusterDomainsWithNoJSHub (1.32s)
```
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
This was referenced Aug 1, 2023
jnmoyne
added a commit
to nats-io/jsm.go
that referenced
this pull request
Aug 3, 2023
jnmoyne
added a commit
that referenced
this pull request
Aug 12, 2023
…am mirror (#4354) - [X] Tests added - [X] Branch rebased on top of current main (`git pull --rebase origin main`) - [X] Changes squashed to a single commit (described [here](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) - [x] Build is green in Travis CI - [X] You have certified that the contribution is your original work and that you license the work to the project under the [Apache 2 license](https://github.com/nats-io/nats-server/blob/main/LICENSE) Follow up to #4276 extending to Mirror the full StreamSource functionality. --------- Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git pull --rebase origin main)Changes proposed in this pull request:
Adds support for multi-filter (and associated transform destinations) to stream sources