Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Fixed deadlock when checkAndSync was being called as part of storing message #4411

Merged
merged 3 commits into from
Aug 21, 2023
Merged

[FIXED] Fixed deadlock when checkAndSync was being called as part of storing message #4411

merged 3 commits into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. Fixed deadlock when checkAndSync was being called as part of storing … 

    …message.

We violated the locking pattern, so we now make sure we do this in a separate Go routine and put checks to only run it once.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e018705 View commit details
    Browse the repository at this point in the history

  2. Remove 1.18 compile build, support 1.19 and above 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    10f73e8 View commit details
    Browse the repository at this point in the history

  3. Should reset to false, not true when done 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    0a86bf4 View commit details
    Browse the repository at this point in the history