Remove subject_transform_dest
#4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
Sep 19, 2023
wallyqs
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jnmoyne
added a commit
to nats-io/nats.go
that referenced
this pull request
Sep 19, 2023
…ce (config and info) see nats-io/nats-server#4557
jnmoyne
added a commit
to nats-io/jsm.go
that referenced
this pull request
Sep 19, 2023
jnmoyne
added a commit
to nats-io/jsm.go
that referenced
this pull request
Sep 19, 2023
jnmoyne
added a commit
to nats-io/jsm.go
that referenced
this pull request
Sep 19, 2023
jnmoyne
added a commit
to nats-io/jsm.go
that referenced
this pull request
Sep 19, 2023
piotrpio
pushed a commit
to nats-io/nats.go
that referenced
this pull request
Sep 19, 2023
…ce (config and info) see nats-io/nats-server#4557
|
If someone has a stream that had this configured and that was saved into the stream config on disk, what happens to them? |
piotrpio
pushed a commit
to nats-io/nats.go
that referenced
this pull request
Sep 19, 2023
…ce (config and info) see nats-io/nats-server#4557
neilalexander
added
the
post-freeze
neilalexander
added a commit
that referenced
this pull request
Sep 19, 2023
This is a safer (less lines of code touched) alternative to #4557 for now, which simply ignores the `subject_transform_dest` field in the API and the stream assignments. We'll still look to merge the other PR to clean up but will do so post-release when we have more time to test it. Signed-off-by: Neil Twigg <neil@nats.io>
piotrpio
pushed a commit
to nats-io/nats.go
that referenced
this pull request
Sep 20, 2023
…ce (config and info) see nats-io/nats-server#4557
Co-authored-by: Jean-Noël Moyne <jnmoyne@gmail.com> Co-authored-by: Neil Twigg <neil@nats.io> Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
jnm/remove_single_transform_from_stream_sources
branch
from
f336a31
to
9fc2603
Compare
|
Rebased on top of |
neilalexander
changed the title
subject_transform_dest
neilalexander
removed
the
post-freeze
neilalexander
approved these changes
Sep 20, 2023
neilalexander
deleted the
jnm/remove_single_transform_from_stream_sources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the single subject transform destination field any subject transformation in StreamSources must now be done using the SubjectTransforms array instead.