Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reloading message for prof_block_rate #4862

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix reloading message for prof_block_rate #4862

merged 2 commits into from
Dec 7, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Dec 7, 2023

Also correcting a few typos in tests that have accumulated.

Changes the reload message to reflect the option name instead: prof_block_rate
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs requested a review from a team as a code owner December 7, 2023 19:52
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 3c48d0e into main Dec 7, 2023
4 checks passed
@derekcollison derekcollison deleted the nits branch December 7, 2023 21:07
ReubenMathew pushed a commit to ReubenMathew/nats-server that referenced this pull request Dec 8, 2023
Revert nats-io#4825. It had at least
one significant issue that needs to be fixed.

`git revert e0d45bd` was clean
wallyqs added a commit that referenced this pull request Dec 11, 2023
Includes the following changes:

- #4861
- #4862
- #4870
- #4869
- #4864
- #4868
nabsul pushed a commit to nabsul/nats-server that referenced this pull request Jan 15, 2024
Revert nats-io#4825. It had at least
one significant issue that needs to be fixed.

`git revert e0d45bd` was clean
levb added a commit to levb/nats-server that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants