Release v2.10.8 cherry picks #4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #4826 Signed-off-by: Sven Neumann <sven.neumann@holoplot.com>
Move matching of filter subject on stream purge to the consumer and add a unit test for it. Signed-off-by: Sven Neumann <sven.neumann@holoplot.com>
Signed-off-by: Sven Neumann <sven.neumann@holoplot.com>
We do not always need the tokenized subject here. Signed-off-by: Sven Neumann <sven.neumann@holoplot.com>
Signed-off-by: Sven Neumann <sven.neumann@holoplot.com>
…lowly back off retries til we hit maximum of 2m. Signed-off-by: Derek Collison <derek@nats.io>
…uests. This was due to the fact the the request was for an R1 consumer with a wildcard filter subject on a large subject space. This will be properly handled in a subsequent PR with a replacement for PSIM and calculating NumPending on a stream. For now, we are doing several changes in this CL. 1. Warn if the internal queue starts to back up past a limit (32 atm). 2. Use multiple Go routines in a pool to process on the other side. 3. Make sure to track inflight properly. We exposed it as an api usage stat for JetStream, but were not properly tracking. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
…rrors and sources after when we receive a response. Also cancel on a timeout since the consumer, even if created after, is of no use to us at this point. Signed-off-by: Derek Collison <derek@nats.io>
…ent. This was causing us to load all blocks to calulate NumPending for a new consumer with LastBySubject delivery. Note this will be drastically improved with stree(ART) in a later PR. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
This does not add tests or docs, this is to sound out how people feel about the API. Turn the TLS options cert_file and key_file into list-separated paths (so colon-delimited if on Unix, like `$PATH`); the count of entries must match, and the keys and certs should zip together. With this change, TLS SNI works to pick the correct cert to return for a given connection, allowing a NATS server to have multiple identities.
```
tls {
certs = [
{
cert_file: "./configs/certs/srva-cert.pem"
key_file: "./configs/certs/srva-key.pem"
},
{
cert_file: "./configs/certs/srvb-cert.pem"
key_file: "./configs/certs/srvb-key.pem"
}
]
ca_file: "./configs/certs/ca.pem"
verify: true
timeout: 2
}
```
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following: