-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
badges: add ArtifactHub; normalize CIIBestPractices #4923
Conversation
Signed-off-by: Phil Pennock <pdp@nats.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BTW https://artifacthub.io/packages/helm/nats/nats says the chart is not official. Considering there are others charts like Bitnami-managed ones (https://artifacthub.io/packages/helm/bitnami/nats), would be nice to claim the |
Thanks @arm4b looks like we can open an issue in artifacts hub so that it is labeled as official. |
I think a flow document I looked at had the link from the README to the helm chart in artifacthub as a pre-requisite for being able to verify the helm chart as official, but I don't have my notes from that available right now, to confirm. |
Could be needed for the And indeed, looks like it should be done via opening an Issue with a request. |
We have an existing Artifacts Hub repository, based on the nats-io/k8s repo.
Including a badge which links to that repository should resolve the "Artifact Hub badge" item in the CLOMonitor report on nats.
While there, normalise the "CII Best Practices" badge to use markdown reference links, the same as all the other badges.
Signed-off-by: Phil Pennock pdp@nats.io