Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badges: add ArtifactHub; normalize CIIBestPractices #4923

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

philpennock
Copy link
Member

We have an existing Artifacts Hub repository, based on the nats-io/k8s repo.

Including a badge which links to that repository should resolve the "Artifact Hub badge" item in the CLOMonitor report on nats.

While there, normalise the "CII Best Practices" badge to use markdown reference links, the same as all the other badges.

Signed-off-by: Phil Pennock pdp@nats.io

Signed-off-by: Phil Pennock <pdp@nats.io>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit ac74f78 into main Jan 4, 2024
4 checks passed
@derekcollison derekcollison deleted the pdp/artifact-hub branch January 4, 2024 04:07
@arm4b
Copy link

arm4b commented Jan 9, 2024

BTW https://artifacthub.io/packages/helm/nats/nats says the chart is not official.

image

Considering there are others charts like Bitnami-managed ones (https://artifacthub.io/packages/helm/bitnami/nats), would be nice to claim the official status here: https://artifacthub.io/docs/topics/repositories/#official-status.

@wallyqs
Copy link
Member

wallyqs commented Jan 9, 2024

Thanks @arm4b looks like we can open an issue in artifacts hub so that it is labeled as official.

wallyqs added a commit that referenced this pull request Jan 9, 2024
Cherry-pick the following PRs into the 2.10.8 release branch:

* #4918 
* #4923
* #4925
* #4926
* #4927
* #4929 
* #4933
* #4835

Signed-off-by: Neil Twigg <neil@nats.io>
@philpennock
Copy link
Member Author

I think a flow document I looked at had the link from the README to the helm chart in artifacthub as a pre-requisite for being able to verify the helm chart as official, but I don't have my notes from that available right now, to confirm.

@arm4b
Copy link

arm4b commented Jan 10, 2024

Could be needed for the verified publisher ArctifactHub badge https://artifacthub.io/docs/topics/repositories/#verified-publisher? Which is already ✅ in place.
Having that as pre-req, it's now possible to get the official ArtifactHub badge per their guide.

And indeed, looks like it should be done via opening an Issue with a request.
Example: https://github.com/artifacthub/hub/issues?q=is%3Aissue+is%3Aclosed+OFFICIAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants