Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stree: Reduce heap escapes in iter #4977

Merged
merged 1 commit into from
Jan 19, 2024
Merged

stree: Reduce heap escapes in iter #4977

merged 1 commit into from
Jan 19, 2024

Conversation

neilalexander
Copy link
Member

When using make(x, y, z), there is a heap escape due to the non-constant size/capacity. Try to stay on the stack instead, reducing GC pressure.

Signed-off-by: Neil Twigg neil@nats.io

When using `make(x, y, z)`, there is a heap escape due to the non-constant
size/capacity. Try to stay on the stack instead, reducing GC pressure.

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner January 19, 2024 12:57
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 6de76a4 into stree Jan 19, 2024
4 checks passed
@derekcollison derekcollison deleted the neil/streeiter branch January 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants