[ADDED] JetStream domain elected advisory for when we have a new meta leader. #5041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-leader. Signed-off-by: Derek Collison <derek@nats.io>
philpennock
approved these changes
Feb 6, 2024
| TypedEvent: TypedEvent{ | ||
| Type: JSDomainLeaderElectedAdvisoryType, | ||
| ID: nuid.Next(), | ||
| Time: time.Now().UTC(), |
There was a problem hiding this comment.
Should this time stamp be obtained while the lock is held, so that we don't report that at time T the leader was in one place when it had actually already moved out, or do we go "it's second resolution, you can't rely on that for anything but informational purposes in the context of subscribing to a complete stream"?
There was a problem hiding this comment.
We are getting the group leader right behind it, so do not think its an issue per se.
ripienaar
reviewed
Feb 6, 2024
Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison derek@nats.io