[FIXED] Stream catchup would not sync after server crash and restart. #5362
+114
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a bug that would overwrite the sync subject during parallel stream creation which would cause upper layer stream cacthups to fail on server restarts. We also were reporting first sequence mismatch when we hot max retries to force a reset but this was misleading, so added in proper error for max retires limit. Signed-off-by: Derek Collison <derek@nats.io>
Consumers could still be catching up as well. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
…heck if beyond a minumum threshold. On an active stream the ack floor periodic checks could trigger just due to normal circumstances, so use minimum threshold. Also do not jump delivered in that logic based on stream sequences. And finally do not have leader jump ack floors when pending is empty, this allows consistency checks to be consistent across all replicas. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug that would overwrite the sync subject during parallel stream creation which would cause upper layer stream catchups to fail on server crash and subsequent restarts.
We also were reporting first sequence mismatch when we hit max retries to force a reset but this was misleading, so added in proper error for max retries limit.
Also on some extreme kill and restart cases our internal checks were being called before complete state was achieved, so delay the initial check and added in periodic checks to ensure replica consistency.
Signed-off-by: Derek Collison derek@nats.io