[IMPROVED] Handling of sourcing into a WQ/Interest streamwith a limit and discard new #5372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and discard new. - Avoids re-scanning the stream to find the consumer's starting sequence number for that source every time. Do not log a warning every time this happens as it becomes constant log spam for something that happens temporarily all the time. - Strengthen test TestJetStreamClusterSourceWorkingQueueWithLimit to also check the payload (to catch for example the same message being sourced more than once, or messages not getting sourced). Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement to the handling of sourcing into a WQ/Interest stream with a limit and discard new.
Avoids re-scanning the stream to find the consumer's starting sequence number for that source every time. Do not log a warning every time this happens as it becomes constant log spam for something that happens temporarily all the time.
Strengthen test TestJetStreamClusterSourceWorkingQueueWithLimit to also check the payload (to catch for example the same message being sourced more than once, or messages not getting sourced).