Commits on May 9, 2024

1. [IMPROVED] Websocket: generating INFO to send to clients …

   PR #4255 added code in generateClientInfoJSON to set the proper
   info Host/Port/TLSAvailable/TLSRequired fields to send to clients.
   
   However, this was requiring a lock but more importantly was computing
   the listener's host/port everytime, which is not necessary since
   this is immutable because we don't support the change during a config
   reload.
   
   Also, the TLSRequired field was set based on the server TLSConfig's
   InsecureSkipVerify value, which is irrelevant for a server. The
   mere presence of a TLSConfig (c.srv.websocket.tls being true) is
   enough.
   
   I have modified the TestWSReloadTLSConfig test to verify that the
   tls block cannot be removed and no_tls set to true, which means
   that tls value can't change. I also added check for the info's
   Host/Port/TLSAvailable/TLSRequired values.
   
   Signed-off-by: Ivan Kozlovic <ivan@synadia.com>

   

   kozlovic committed May 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 63204b7
   • Browse repository at this point

   Copy the full SHA

   63204b7 View commit details

   Browse the repository at this point in the history