Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] checkSkipFirstBlock could return negative index if psim.fblk outdated. #5630

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[FIXED] checkSkipFirstBlock could return negative index if psim.fblk outdated. #5630

merged 1 commit into from
Jul 9, 2024
+65 −4

Conversation

derekcollison
Copy link
Member

This would cause LoadNextMsg() to return EOF incorrectly.

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
checkSkipFirstBlock could return negative index if psim.fblk outdated…
f83d000 
…, causing LoadNextMsg() to return EOF.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner July 9, 2024 00:30
wallyqs
wallyqs approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit ed7ab4c into main Jul 9, 2024
3 checks passed
@derekcollison derekcollison deleted the check-skip-first-bug branch July 9, 2024 01:42
@wallyqs wallyqs mentioned this pull request Jul 9, 2024
Merged
wallyqs added a commit that referenced this pull request Jul 9, 2024
@wallyqs
Cherry-picks for 2.10.18-RC.1 (#5634)
d84c468 
Includes:

- #5610
- #5618
- #5616
- #5627
- #5629
- #5630
- #5632
- #5635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derekcollison @wallyqs