[ADDED] Cluster tls insecure configuration #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
approved these changes
Mar 7, 2019
|
@wallyqs I have updated the PR: since we use parseTLS (and getTLSConfig) in various places, and we have an exported GenTLSConfig(), I moved the setting into that function. However, when creating the server (NewServer()), I now reject InsecureSkipVerify if set in anything but the Cluster config. Let me know what you think. |
Based on @softkbot PR #913. Removed the command line parameter, which then removes the need for Options.Cluster.TLSInsecure. Added a test with config reload. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
force-pushed
the
cluster_tls_insecure
branch
from
60e2dfe
to
83aefdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @softkbot PR #913.
Removed the command line parameter, which then removes the need for Options.Cluster.TLSInsecure.
Added a test with config reload.
/cc @nats-io/core