Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test gateway tlsConfig.ServerName #943

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

kozlovic
Copy link
Member

Checks that if not provided server fails to connect to remote
gateway. Once set to expected hostname ("localhost"), connection
works.

Related to PR: #922

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Checks that if not provided server fails to connect to remote
gateway. Once set to expected hostname ("localhost"), connection
works.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 90.435% when pulling 4ea9633 on add_tlsconfig_server_name_test into 172eca6 on master.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 1777e2d into master Apr 15, 2019
@kozlovic kozlovic deleted the add_tlsconfig_server_name_test branch April 15, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants