[FIXED] Check expected record size before loading the payload #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverted addition of record_size_limit But still address the memory usage caused by a corrupted data message on recovery. By using the expected record size from the index file, when checking that the last message matches the index information, we would find out that the index's stored message record size does not match the record size in the ".dat" file and would not allocate the memory to read the rest of the message. The record_size_limit that was added to solve that issue would have likely caused a lot of issues if mis-used. Resolves #1255 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
aricart
reviewed
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted addition of record_size_limit (#1259, #1260, #1262)
But still address the memory usage caused by a corrupted data message
on recovery.
By using the expected record size from the index file, when checking
that the last message matches the index information, we would find
out that the index's stored message record size does not match the
record size in the ".dat" file and would not allocate the memory
to read the rest of the message.
The record_size_limit that was added to solve that issue would have
likely caused a lot of issues if mis-used.
Resolves #1255
Signed-off-by: Ivan Kozlovic ivan@synadia.com