Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Support for redelivery count #997

Merged
merged 1 commit into from Dec 20, 2019
Merged

Conversation

kozlovic
Copy link
Member

The redelivery count is not persisted. It is per subscription or
for a queue group.

Resolves #996

Signed-off-by: Ivan Kozlovic ivan@synadia.com

The redelivery count is not persisted. It is per subscription or
for a queue group.

Resolves #996

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 92.084% when pulling 7436801 on add_redelivery_count into 73a47ce on master.

@kozlovic kozlovic merged commit 89396be into master Dec 20, 2019
@kozlovic kozlovic deleted the add_redelivery_count branch December 20, 2019 20:45
kozlovic added a commit that referenced this pull request May 17, 2021
PR #997 introduced a map to keep track of how many times a message
was redelivered to a subscription (or a queue group). However, sequences
added to this map was never removed when the ACK was processed from
the subscription!

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RedeliveryCount support
3 participants