use reflect.DeepEqual for advisory/observation config equality (#185)

Signed-off-by: Caleb Lloyd <caleb@synadia.com>
nats-io · Feb 14, 2024 · 5df03d9 · 5df03d9
1 parent 898d712
commit 5df03d9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/surveyor/jetstream_advisories.go b/surveyor/jetstream_advisories.go
@@ -19,6 +19,7 @@ import (
 	"io/fs"
 	"os"
 	"path/filepath"
+	"reflect"
 	"regexp"
 	"strings"
 	"sync"
@@ -665,7 +666,7 @@ func (am *JSAdvisoryManager) Set(config *JSAdvisoryConfig) error {
 	existingAdv, found := am.listenerMap[config.ID]
 	am.Unlock()
 
-	if found && *config == *existingAdv.config {
+	if found && reflect.DeepEqual(config, existingAdv.config) {
 		return nil
 	}
 

diff --git a/surveyor/observation.go b/surveyor/observation.go
@@ -20,6 +20,7 @@ import (
 	"io/fs"
 	"os"
 	"path/filepath"
+	"reflect"
 	"strconv"
 	"strings"
 	"sync"
@@ -468,7 +469,7 @@ func (om *ServiceObsManager) Set(config *ServiceObsConfig) error {
 	existingObs, found := om.listenerMap[config.ID]
 	om.Unlock()
 
-	if found && *config == *existingObs.config {
+	if found && reflect.DeepEqual(config, existingObs.config) {
 		return nil
 	}