Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use reflect.DeepEqual for advisory/observation config equality #185

Merged
merged 1 commit into from
Feb 14, 2024
Merged

use reflect.DeepEqual for advisory/observation config equality #185

merged 1 commit into from
Feb 14, 2024

Conversation

caleblloyd
Copy link
Collaborator

Struct equality is no longer guaranteed to work ever since *ServiceObservationExternalAccountConfig was added to ServiceObsConfig, and *JSAdvisoriesExternalAccountConfig was added to JSAdvisoryConfig

Use reflect.DeepEqual instead, so that pointer types are de-referenced for equality checks

@caleblloyd
use reflect.DeepEqual for advisory/observation config equality
c3e9829 
Signed-off-by: Caleb Lloyd <caleb@synadia.com>
samuelattwood
samuelattwood approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@samuelattwood samuelattwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caleblloyd caleblloyd merged commit 5df03d9 into main Feb 14, 2024
2 checks passed
@caleblloyd caleblloyd deleted the observation-advisory-equal branch February 14, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelattwood samuelattwood samuelattwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caleblloyd @samuelattwood