Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes to ordered consumer #602

Merged
merged 1 commit into from
Oct 7, 2022
Merged

More fixes to ordered consumer #602

merged 1 commit into from
Oct 7, 2022

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Oct 7, 2022

  • Ensure that we set the jsi->consumer only on when the consumer's delivery subject matches the subscription's current subject. This is really because of tests with very low HB.
  • Copy the consumer name in natsSubscription_GetInfo() in case the name would be freed during a reconnect.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

- Ensure that we set the jsi->consumer only on when the consumer's
delivery subject matches the subscription's current subject. This
is really because of tests with very low HB.
- Copy the consumer name in natsSubscription_GetInfo() in case
the name would be freed during a reconnect.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 7d25da2 into main Oct 7, 2022
@kozlovic kozlovic deleted the js_oc_issues2 branch October 7, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants