Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] GH-736: added extern to micro_Errors #743

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

levb
Copy link
Collaborator

@levb levb commented Apr 11, 2024

In #731 I wrongly assumed that NATS_EXTERN was a superset of extern and it is not.

Unfortunately, our current CI set up does not catch these, I will revive the GH actions PR that used the more recent compiler versions.

Fixes #736

@levb levb requested a review from kozlovic April 11, 2024 11:09
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb merged commit 726f870 into main Apr 12, 2024
2 checks passed
@levb levb deleted the lev-fix-extern-micro branch April 12, 2024 12:23
github-actions bot pushed a commit that referenced this pull request Apr 12, 2024
levb added a commit that referenced this pull request Apr 12, 2024
…_Errors (#743) (#745)

Co-authored-by: levb <1187448+levb@users.noreply.github.com>
levb added a commit that referenced this pull request Apr 12, 2024
@levb levb removed the cherry-pick label Apr 12, 2024
@levb
Copy link
Collaborator Author

levb commented Apr 12, 2024

Cherry-picked for v3.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error on Linux
2 participants