Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup CI builds #2

Closed
mmmries opened this issue Mar 23, 2017 · 0 comments
Closed

Setup CI builds #2

mmmries opened this issue Mar 23, 2017 · 0 comments
Assignees
@mmmries

Comments

@mmmries
Copy link
Collaborator

mmmries commented Mar 23, 2017

No description provided.

@mmmries mmmries self-assigned this Mar 23, 2017
@mmmries mmmries mentioned this issue Mar 23, 2017
Merged
newellista pushed a commit that referenced this issue Mar 23, 2017
PING/PONG -- Take #2
4ab08f5 
This is the second implementation handling PING/PONG.

It feels a little cleaner, and the code is a bit simpler.

EXCEPT:

The parser generates an "artificial" message containing empty `sid` and
`body` fields.  Probably not a big deal, but looks a little strange.

Resolves #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmries mmmries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmmries