Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support PING-PONG #12

Closed
mmmries opened this issue Mar 23, 2017 · 0 comments
Closed

support PING-PONG #12

mmmries opened this issue Mar 23, 2017 · 0 comments
Assignees
@newellista

Comments

@mmmries
Copy link
Collaborator

mmmries commented Mar 23, 2017

No description provided.

@newellista newellista self-assigned this Mar 23, 2017
newellista pushed a commit that referenced this issue Mar 23, 2017
PING/PONG
b50df4a 
This will reply to server `PING` messages.

This is the first iteration.  There is another PR with a different
solution.

PROS:

  * Simpler parser
  * Message isn't "misrepresented" from the parser.  It returns just the
  `PING`, not manufacturing fake `sid` or `body`

CONS:
  * Handler is a little funky.  Since the message is a different format,
  it requires a bit more work in the handler to deal with the
  differences.

Resolves #12
@newellista newellista mentioned this issue Mar 23, 2017
Merged
newellista pushed a commit that referenced this issue Mar 23, 2017
PING/PONG -- Take #2
4ab08f5 
This is the second implementation handling PING/PONG.

It feels a little cleaner, and the code is a bit simpler.

EXCEPT:

The parser generates an "artificial" message containing empty `sid` and
`body` fields.  Probably not a big deal, but looks a little strange.

Resolves #12
@newellista newellista mentioned this issue Mar 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@newellista newellista

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@newellista @mmmries