Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic tls #37

Merged
merged 6 commits into from
Apr 13, 2017
Merged

Basic tls #37

merged 6 commits into from
Apr 13, 2017

Conversation

mmmries
Copy link
Collaborator

@mmmries mmmries commented Apr 13, 2017

Resolves #30

This PR just handles the very basic case where the client has been started with tls: true and the server has tls_required: true settings. I will follow it up with at least 2 more PRs:

  • handle cases where the server and client mismatch on requiring TLS
  • refactoring the handshake into its own module and passing the entire state to socket_write and socket_close rather than pulling pieces out of the state

I wanted to get this PR opened before tackling either of those other changes since it is already a bit large.

/cc @tallguy-hackett @newellista @film42 @jjcarstens

@mmmries
Copy link
Collaborator Author

mmmries commented Apr 13, 2017

💥 Travis ran for 44 seconds to do all test cases

@mmmries mmmries merged commit 8099506 into master Apr 13, 2017
@mmmries mmmries deleted the basic_tls branch April 13, 2017 14:33
This was referenced Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TLS Connections
2 participants