Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #37 I was bugged by the fact that we had several functions in the
Gnat
module that were only useful for the handshake. I thought it would be nicer to let all of the handshake logic happen in its own module with just a simple{:ok, socket}
or{:error, reason}
return value.I also didn't like constantly having to to do
So I changed the
socket_write
andsocket_close
functions to just accept the entire state as the first argument and it extracts the options/socket as needed./cc @quixoten @film42 @newellista @jjcarstens @tallguy-hackett