-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link not allowed in put meta #1057
Conversation
scottf
commented
Aug 30, 2022
•
edited
Loading
edited
- Prevented links in meta data for puts
- refactored for common publish meta functionality
- Converted all loose errors to vars.
- Updated unit test to check and cover errors.
Tests are failing
|
I see why. AddLink /Add Bucket Link call put with no data, I think because they were worried about when the link would overwrite an object and wanted to delete the chunks. But we don't allow a link to overwrite an object now. I'll fix. |
…ata, they can just publish the object info (meta)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…to vars. Updated unit test to check and cover errors.
The build is failing (staticcheck):
Other than that, looks good. |