Service Beta #813
Merged
Service Beta #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauriceVanVeen
approved these changes
Dec 14, 2022
aricart
approved these changes
Dec 16, 2022
| public static final Duration DEFAULT_DRAIN_TIMEOUT = Duration.ofSeconds(5); | ||
| public static final long DEFAULT_DISCOVERY_MAX_TIME_MILLIS = 5000; | ||
| public static final int DEFAULT_DISCOVERY_MAX_RESULTS = 10; | ||
|
|
There was a problem hiding this comment.
baseSubject is your action above, why not call it the same
There was a problem hiding this comment.
Also with the exception of the prefix - if one is given to straddle account boundaries, all other tokens (verb, name, id) should be uppercase.
There was a problem hiding this comment.
Yeah, prefix replacement is unresolved so I wouldn't worry about his for right now. It will be addressed when the decision about how to modify the prefix for across account is made. Will it be done KV/Object Store style or will it be done JS Prefix style?
|
I am writing a tool that you can use to verify that your service is cross-implementation compatible with respect to the monitoring apis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.