Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client side check against server info max_payload when publishing #922

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Jun 8, 2023

It's up to the developer to ensure that they publish within their limits. The idea here is that he client might be connected to a node that doesn't know your server payload configuration because it's a leaf node for instance. The client can't with certainty know what your limits are, so it's better for the destination server to be the source of truth.

Copy link
Contributor

@RichardHightower RichardHightower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 0e247c2 into main Jun 8, 2023
1 check passed
@scottf scottf deleted the remove_max_payload_check branch June 8, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants