Skip to content

1.0.7 Bug Fix
Compare
Choose a tag to compare
@scottf scottf released this 12 Jul 18:01
1.0.7
7a773e5
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Bug fix

This replaces both 1.0.5 and 1.0.6 as this bug was introduced in 1.0.5

When refactoring pull sync subscription class to have shared base abstract code in common with the push subscription, the push sync subscription class was copied to the abstract class, but was not changed to inherit from it. This caused calls to sub.GetConsumerInfo to fail, since it didn't properly have the consumer name.
This affects all Push subscriptions if the dev calls sub.GetConsumerInfo, thankfully that's fairly uncommon. But...KeyValue watches use push under the covers and immediately call sub.GetConsumerInfo, so immediately fails.

Thanks @jlumsden-mts for reporting the issue with a repeatable test case.

Contributors

jlumsden-mts
Assets 2