Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected port when connecting through secure websocket (wss) #360

Closed
bvanelli opened this issue Oct 4, 2022 · 0 comments · Fixed by #371
Closed

Unexpected port when connecting through secure websocket (wss) #360

bvanelli opened this issue Oct 4, 2022 · 0 comments · Fixed by #371

Comments

@bvanelli
Copy link
Contributor

bvanelli commented Oct 4, 2022

There are some small issues left when connecting with a secure websocket (wss) without specifying a port, as it gets treated by the following else statement:

https://github.com/nats-io/nats.py/blob/main/nats/aio/client.py#L1234

That then changes the protocol unexpectedly. The correct behavior should be to instead use port 443 as default, assuming websocket is being served in the default tls port.

Also, this replacements do not support proxies (i.e. traefik) as the path name would be omitted.

I'll send a mr for this one 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant