Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where protocol was changed for ws and wss if no port was provided. #371

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Fix issue where protocol was changed for ws and wss if no port was provided. #371

merged 1 commit into from
Oct 8, 2022

Conversation

bvanelli
Copy link
Contributor

@bvanelli bvanelli commented Oct 8, 2022

Fixes #360

wallyqs
wallyqs approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 5a698b9 into nats-io:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected port when connecting through secure websocket (wss)
2 participants
@bvanelli @wallyqs