Support sending requests with reconnected client #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug (or at least a non documented behaviour). It brings very little change to the codebase.
Problem description
Reproducible example:
Objectives of the PR
Proposal implementation
Client._resp_sub_prefix
at the end of theClient._close
method.I saw that
Client._client_id
is already resetted at that time, so I though that it was the right place to resetClient._resp_sub_prefix
too.How was this PR tested ?
I added a single test which is very similar to the example above. If we can talk to NATS server, then a request on a subject without subjecription must raise a
NoRespondersError
, if not, aTimeoutError
is raised and test fails.