Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join all connect threads while closing connection #305

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Join all connect threads while closing connection #305

merged 1 commit into from
Jan 25, 2022

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jan 18, 2022 •
edited
Loading

closes #300

caspervonb
caspervonb reviewed Jan 18, 2022
View reviewed changes
src/client.rs Outdated Show resolved Hide resolved
@Jarema
Copy link
Member Author

Jarema commented Jan 19, 2022 •
edited
Loading

Drop on Inner starts shutdown, but shutdown itself does not wait until it's finished, just triggers it.

We might have more things happening in drop, WDYT @caspervonb ?

@caspervonb
Copy link
Collaborator

caspervonb commented Jan 19, 2022 •
edited
Loading

Drop on Inner starts shutdown, but shutdown itself does not wait until it's finished, just triggers it.

Already clarified offline but for completeness yes, let's call close 👍

@Jarema
Copy link
Member Author

Jarema commented Jan 20, 2022

@caspervonb Added break in flush thread, so closing client on dropped server won't hang.

@Jarema Jarema merged commit 051e651 into main Jan 25, 2022
@Jarema Jarema deleted the jarema/fix-threads-join branch January 25, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Threads are not stopped on drop/close()
2 participants
@Jarema @caspervonb