Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test linter warnings #379

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Fix test linter warnings #379

merged 2 commits into from
Apr 20, 2022

Conversation

caspervonb
Copy link
Collaborator

No description provided.

@caspervonb caspervonb changed the title Fix test lint Fix test lints Apr 20, 2022
@caspervonb caspervonb changed the title Fix test lints Fix test linter warnings Apr 20, 2022
@caspervonb caspervonb requested a review from Jarema April 20, 2022 04:13
Jarema
Jarema approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caspervonb
Copy link
Collaborator Author

Want to treat warnings as errors on CI @Jarema?

@caspervonb caspervonb marked this pull request as ready for review April 20, 2022 04:33
@caspervonb caspervonb merged commit 8ed6a89 into nats-io:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caspervonb @Jarema