Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow parse message data as json #816

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

xoac
Copy link
Contributor

@xoac xoac commented Jan 20, 2023

No description provided.

@Jarema
Copy link
Member

Jarema commented Jan 23, 2023

Thanks for your contribution @xoac !

Are you sure you wanted to update just the example?

Besides:
For any nats cli experience, I would stick to https://github.com/nats-io/natscli , which is a very powerful tool.

For any code-related work, I would use async-nats crate.

@xoac
Copy link
Contributor Author

xoac commented Jan 23, 2023

Hi @Jarema it works well and it's simpler CLI for testing than natscli. The code of rust version is shorter than the README.md of natscli and I don't need to install yet another language compiler. I just pushed PR because I wanted to print the json format of messages that I publish with async-nats ;)

Are you sure you wanted to update just the example?

What else you want update here?

@Jarema
Copy link
Member

Jarema commented Jan 23, 2023

What else you want update here?

I meant that this is just a short example how library can be used :).

Just FYI - you don't need Go compiler to work with CLI, nor read much of the docs. it's the same nats pub and nats sub.
It's available as released binary and in some package managers.

As said, as this is just an example, I have no problems with merging it if that helps you.

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xoac
Copy link
Contributor Author

xoac commented Jan 23, 2023

I meant that this is just a short example how library can be used :).

It's short and simple - exactly what I am looking for and I was able to use this in 2min when I wasn't able to install natscli in 2min 乁(⫑ᴥ⫒)ㄏ (no golang, not included with my distro. I don't download libraries that can't be updated automatically). I am not saying that natscli is bad or sth - but I use rust on daily basic and this is just simpler for me. I guess for golang people it would be easier just go with natscli.

@Jarema Jarema merged commit 16306f6 into nats-io:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants