Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Command private #953

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

caspervonb
Copy link
Collaborator

@caspervonb caspervonb commented May 3, 2023

This type is just used internally to communicate with the internal connection handler and not publicly useful to anyone.

@caspervonb caspervonb requested a review from Jarema May 3, 2023 08:48
@caspervonb caspervonb marked this pull request as draft May 3, 2023 09:07
@caspervonb caspervonb force-pushed the make-command-private branch 3 times, most recently from 73a2846 to bae04f6 Compare May 3, 2023 10:58
@caspervonb caspervonb marked this pull request as ready for review May 3, 2023 14:38
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit a6b5b2f into nats-io:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants