Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firefox zombie connections #207

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Fix Firefox zombie connections #207

merged 1 commit into from
Aug 15, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Aug 1, 2023

[FIX] some websocket runtimes, will not close the socket when asked to, so it is possible for the websocket transport to realize and start emitting data to the base library. This change prepares the client for this type of coordination

FIX #172

…o, so it is possible for the websocket transport to realize and start emitting data to the base library. This change prepares the client for this type of coordination

FIX #172
@aricart aricart temporarily deployed to CI August 1, 2023 19:55 — with GitHub Actions Inactive
@aricart aricart requested a review from Jarema August 1, 2023 20:07
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 6d1a993 into main Aug 15, 2023
2 checks passed
@aricart aricart deleted the fix-172 branch March 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocket connection retry handling is severely broken in Firefox
2 participants