Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reworked npm bundle to have cjs as this may help folks that are transpiling #91

Merged
merged 9 commits into from
Mar 29, 2021

Conversation

aricart
Copy link
Member

@aricart aricart commented Mar 27, 2021

No description provided.

@aricart aricart temporarily deployed to CI March 27, 2021 16:58 Inactive
@aricart
Copy link
Member Author

aricart commented Mar 27, 2021

@ValentinH does this work with your setup

package.json Outdated Show resolved Hide resolved
@aricart aricart temporarily deployed to CI March 27, 2021 19:10 Inactive
@aricart aricart temporarily deployed to CI March 27, 2021 19:10 Inactive
@aricart aricart temporarily deployed to CI March 27, 2021 21:01 Inactive
@aricart aricart temporarily deployed to CI March 27, 2021 21:01 Inactive
Co-authored-by: Valentin Hervieu <ValentinH@users.noreply.github.com>
@aricart aricart temporarily deployed to CI March 27, 2021 21:02 Inactive
@aricart aricart temporarily deployed to CI March 27, 2021 21:02 Inactive
@aricart aricart temporarily deployed to CI March 27, 2021 21:02 Inactive
@aricart aricart requested a review from kozlovic March 27, 2021 21:03
@aricart aricart temporarily deployed to CI March 27, 2021 21:05 Inactive
@aricart aricart temporarily deployed to CI March 27, 2021 21:05 Inactive
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Rename mjs to es.js

.mjs extension are not supported properly by the Webpack tools.

* Renam nats.js to .cjs
@aricart aricart temporarily deployed to CI March 29, 2021 20:06 Inactive
@aricart aricart temporarily deployed to CI March 29, 2021 20:06 Inactive
@aricart aricart temporarily deployed to CI March 29, 2021 20:35 Inactive
@aricart aricart temporarily deployed to CI March 29, 2021 20:35 Inactive
@aricart aricart merged commit 4fbb841 into master Mar 29, 2021
@aricart aricart deleted the cjs branch March 29, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants