[CHANGED] MaxPubAcksInFlight to MaxPubAcksInflight

The introduced option setter had a case that did not match the
option it is setting and the similar Subscription's option
MaxInflight

Related to PR #88

examples/stan-bench.go

@@ -102,16 +102,9 @@ func main() {
 	}
 }
 
-func setMaxPubAcksInflight(val int) stan.Option {
-	return func(o *stan.Options) error {
-		o.MaxPubAcksInflight = val
-		return nil
-	}
-}
-
-func runPublisher(startwg, donewg *sync.WaitGroup, opts nats.Options, numMsgs int, msgSize int, async bool, pubID string, maxPubAcksInFlight int) {
+func runPublisher(startwg, donewg *sync.WaitGroup, opts nats.Options, numMsgs int, msgSize int, async bool, pubID string, maxPubAcksInflight int) {
 
-	snc, err := stan.Connect("test-cluster", pubID, setMaxPubAcksInflight(maxPubAcksInFlight))
+	snc, err := stan.Connect("test-cluster", pubID, stan.MaxPubAcksInflight(maxPubAcksInflight))
 	if err != nil {
 		log.Fatalf("Publisher %s can't connect: %v\n", pubID, err)
 	}

stan.go

@@ -114,9 +114,9 @@ func PubAckWait(t time.Duration) Option {
 	}
 }
 
-// MaxPubAcksInFlight is an Option to set the maximum number of published
+// MaxPubAcksInflight is an Option to set the maximum number of published
 // messages without outstanding ACKs from the server.
-func MaxPubAcksInFlight(max int) Option {
+func MaxPubAcksInflight(max int) Option {
 	return func(o *Options) error {
 		o.MaxPubAcksInflight = max
 		return nil

stan_test.go

@@ -1091,7 +1091,7 @@ func TestRedelivery(t *testing.T) {
 	}
 }
 
-func TestRedeliveryHonorMaxInFlight(t *testing.T) {
+func TestRedeliveryHonorMaxInflight(t *testing.T) {
 	// Run a NATS Streaming server
 	s := RunServer(clusterName)
 	defer s.Shutdown()
@@ -1889,7 +1889,7 @@ func TestNatsConn(t *testing.T) {
 	}
 }
 
-func TestMaxPubAcksInFlight(t *testing.T) {
+func TestMaxPubAcksInflight(t *testing.T) {
 	s := RunServer(clusterName)
 	defer s.Shutdown()
 
@@ -1900,7 +1900,7 @@ func TestMaxPubAcksInFlight(t *testing.T) {
 	defer nc.Close()
 
 	sc, err := Connect(clusterName, clientName,
-		MaxPubAcksInFlight(1),
+		MaxPubAcksInflight(1),
 		PubAckWait(time.Second),
 		NatsConn(nc))
 	if err != nil {
@@ -1914,7 +1914,7 @@ func TestMaxPubAcksInFlight(t *testing.T) {
 
 	msg := []byte("hello")
 
-	// Send more than one message, if MaxPubAcksInFlight() works, one
+	// Send more than one message, if MaxPubAcksInflight() works, one
 	// of the publish call should block for up to PubAckWait.
 	start := time.Now()
 	for i := 0; i < 2; i++ {